Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44300: [Integration][Archery] Don't import unused testers #44301

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 4, 2024

Rationale for this change

Some testers such as JavaTester may raise an exception on import when the target implementation isn't built. It stops integration test unexpectedly.

What changes are included in this PR?

Import testers only for enabled implementations.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Some testers such as `JavaTester` may raise an exception on import
when the target implementation isn't built. It stops integration test
unexpectedly.
Copy link

github-actions bot commented Oct 4, 2024

⚠️ GitHub issue #44300 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 4, 2024
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 4, 2024
@raulcd raulcd merged commit ad136d8 into apache:main Oct 4, 2024
8 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 4, 2024
@kou kou deleted the archery-integration-tester branch October 4, 2024 11:34
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ad136d8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants